chore(all): enable tsconfig noUnusedLocals compiler option#17541
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 31, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Sysix
force-pushed
the
12-31-chore_enable_tsconfig_nounusedlocals_compiler_option
branch
from
53a3211 to
a91cd64
Compare
github-actions
bot
added
A-linter
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables the noUnusedLocals TypeScript compiler option across all tsconfig.json files in the project to catch unused local variables during compilation, addressing a gap where @typescript-eslint/no-unused-vars was not reporting these issues.
Key Changes:
- Added
"noUnusedLocals": trueto 8 tsconfig.json files across different project directories - Removed an unused
linterVersionfield from the LinterTool class in the VSCode extension
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tasks/e2e/tsconfig.json | Added noUnusedLocals compiler option |
| plugins/tsconfig.json | Added noUnusedLocals compiler option |
| napi/transform/tsconfig.json | Added noUnusedLocals compiler option |
| napi/parser/tsconfig.json | Added noUnusedLocals compiler option |
| napi/minify/tsconfig.json | Added noUnusedLocals compiler option |
| editors/vscode/tsconfig.json | Added noUnusedLocals compiler option |
| editors/vscode/client/tools/linter.ts | Removed unused linterVersion property that was caught by the new compiler option |
| apps/oxlint/tsconfig.json | Added noUnusedLocals compiler option |
| apps/oxfmt/tsconfig.json | Added noUnusedLocals compiler option |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
camc314
changed the title
noUnusedLocals compiler optionnoUnusedLocals compiler option
github-actions
bot
added
the
C-cleanup
Contributor
Merge activity
|
Unused local variables did not get reported by `@typescript-eslint/no-unused-vars`. Added `noUnusedLocals` check for every tsconfig, so `pnpm lint` will report them. Example of failed CI: https://github.com/oxc-project/oxc/actions/runs/20626453016/job/59237769046?pr=17541
graphite-app
bot
force-pushed
the
12-31-chore_enable_tsconfig_nounusedlocals_compiler_option
branch
from
a91cd64 to
e8e42eb
Compare
graphite-app
bot
deleted the
12-31-chore_enable_tsconfig_nounusedlocals_compiler_option
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unused local variables did not get reported by
@typescript-eslint/no-unused-vars.Added
noUnusedLocalscheck for every tsconfig, sopnpm lintwill report them.Example of failed CI: https://github.com/oxc-project/oxc/actions/runs/20626453016/job/59237769046?pr=17541